GitLab

Keeps the non-obvious rationale (pod naming, repository injection, one-shot
promise settling, optional guards) and drops restatements of what the code
already shows.

Verified against the MyID backend: a non-UUID sessionId is rejected with code
103 before the SDK UI appears.

The demo hardcoded light-theme colors with no explicit background, so on a
device in dark mode the title and input text rendered dark-on-dark.

Three paths overwrote SDK defaults instead of leaving them alone:

- iOS assigned every appearance color unconditionally, so theming one color
  nil-ed the other eleven. MyIdAppearance seeds its own values.
- An organizationDetails carrying only a logo replaced the whole details object,
  clearing the default call-centre number. It is now forwarded only when the
  caller supplied a field, and each field is assigned individually.
- An unrecognised enum value called the setter with a guessed default. The guess
  was not always right: the SDK defaults imageFormat to JPEG while the fallback
  substituted PNG. Unknown values now skip the setter.

Android settled a promise through a plain field touched by the JS, UI and
native-modules threads, giving neither visibility nor an atomic check-then-set;
a reload racing a start could wedge the module for the rest of the process. It
is now an AtomicReference claimed with compareAndSet, and the result listener is
scoped to a flow id so a late duplicate callback cannot settle a newer promise.

iOS gained the invalidate path Android already had, confines its state to the
main queue, and extends the proxy's lifetime across the settle callback that
releases it.

Documented defaults corrected against MyIdDefaults: imageFormat is JPEG,
withSoundGuides is true, distance depends on camera shape, iOS floor is 15.1.

Covers the per-build-type Gradle fallback, the central-repository opt-out, the
arm-only ABI constraint that breaks x86 emulators, and the Android theming
path, none of which are discoverable from the API surface.

Credentials are entered at runtime instead of hardcoded so the example can be
shared without leaking a client hash, and the result view renders the returned
portrait to prove the base64 payload decodes.

ObjC++ flattens the codegen C++ param structs into NSDictionary, since Swift
cannot see them, and delegates to a Swift layer that owns all SDK interaction.

The pod is named RNMyidSdk rather than MyidSdk: the latter differs from the
vendor pod MyIdSDK only by case, and on a case-insensitive filesystem the two
targets share one intermediate build directory, so the generated Swift header
lands in the vendor's directory and the bridge fails to import it.

MyIdClientDelegate conformance is kept on an internal proxy so it is not
re-emitted into the generated Swift header, which ObjC++ parses without any
visibility of MyIdSDK's Swift types.

Maps the JS config onto MyIdConfig.Builder, launches the SDK via
startActivityForResult and settles a single pending promise from the
activity-result callback.

handleActivityResult does not inspect the request code, so the listener filters
on its own code first to avoid settling the promise from an unrelated result.

MyID artifacts are not on Maven Central, and a consuming app re-resolves
transitive dependencies against its own repository set, so the repositories are
registered on all projects rather than only on this module. An opt-out property
is provided for apps that manage repositories centrally.

Public surface is a promise-based start({config, iosAppearance}) mirroring the
MyID Flutter plugin's wire format, with string-union enums, platform-scoped
JSDoc and a MyIdError carrying the SDK result code.

The codegen spec stays deliberately untyped for enums because codegen cannot
express string unions; narrowing lives in the public layer only. Keys that are
undefined are stripped before crossing the bridge so the SDK's own defaults
survive rather than being overwritten with empty values.

Repo becomes the myid-sdk npm package: library at root, RN 0.86.2 vanilla
example app in example/, Turbo Module codegen enabled, yarn 4 workspace.

The previous demo app targeted MyID SDK 2.x (clientId, withPassportData,
MyIdBuildMode), an API that no longer exists in 3.x, so it is removed rather
than migrated. Recoverable via the pre-rewrite tag.