• Javokhir's avatar
    fix: preserve SDK defaults and make promise settling thread-safe · 44516365
    Javokhir authored
    Three paths overwrote SDK defaults instead of leaving them alone:
    
    - iOS assigned every appearance color unconditionally, so theming one color
      nil-ed the other eleven. MyIdAppearance seeds its own values.
    - An organizationDetails carrying only a logo replaced the whole details object,
      clearing the default call-centre number. It is now forwarded only when the
      caller supplied a field, and each field is assigned individually.
    - An unrecognised enum value called the setter with a guessed default. The guess
      was not always right: the SDK defaults imageFormat to JPEG while the fallback
      substituted PNG. Unknown values now skip the setter.
    
    Android settled a promise through a plain field touched by the JS, UI and
    native-modules threads, giving neither visibility nor an atomic check-then-set;
    a reload racing a start could wedge the module for the rest of the process. It
    is now an AtomicReference claimed with compareAndSet, and the result listener is
    scoped to a flow id so a late duplicate callback cannot settle a newer promise.
    
    iOS gained the invalidate path Android already had, confines its state to the
    main queue, and extends the proxy's lifetime across the settle callback that
    releases it.
    
    Documented defaults corrected against MyIdDefaults: imageFormat is JPEG,
    withSoundGuides is true, distance depends on camera shape, iOS floor is 15.1.
    44516365
myid-types.ts 4.97 KB