1. 16 Sep, 2026 4 commits
    • Javokhir's avatar
      refactor: tighten inline comments across the native bridge · befb2c86
      Javokhir authored
      Keeps the non-obvious rationale (pod naming, repository injection, one-shot
      promise settling, optional guards) and drops restatements of what the code
      already shows.
      befb2c86
    • Javokhir's avatar
      fix: preserve SDK defaults and make promise settling thread-safe · 44516365
      Javokhir authored
      Three paths overwrote SDK defaults instead of leaving them alone:
      
      - iOS assigned every appearance color unconditionally, so theming one color
        nil-ed the other eleven. MyIdAppearance seeds its own values.
      - An organizationDetails carrying only a logo replaced the whole details object,
        clearing the default call-centre number. It is now forwarded only when the
        caller supplied a field, and each field is assigned individually.
      - An unrecognised enum value called the setter with a guessed default. The guess
        was not always right: the SDK defaults imageFormat to JPEG while the fallback
        substituted PNG. Unknown values now skip the setter.
      
      Android settled a promise through a plain field touched by the JS, UI and
      native-modules threads, giving neither visibility nor an atomic check-then-set;
      a reload racing a start could wedge the module for the rest of the process. It
      is now an AtomicReference claimed with compareAndSet, and the result listener is
      scoped to a flow id so a late duplicate callback cannot settle a newer promise.
      
      iOS gained the invalidate path Android already had, confines its state to the
      main queue, and extends the proxy's lifetime across the settle callback that
      releases it.
      
      Documented defaults corrected against MyIdDefaults: imageFormat is JPEG,
      withSoundGuides is true, distance depends on camera shape, iOS floor is 15.1.
      44516365
    • Javokhir's avatar
      feat(android): implement MyID turbo module against capture SDK 3.1.9 · f790805c
      Javokhir authored
      Maps the JS config onto MyIdConfig.Builder, launches the SDK via
      startActivityForResult and settles a single pending promise from the
      activity-result callback.
      
      handleActivityResult does not inspect the request code, so the listener filters
      on its own code first to avoid settling the promise from an unrelated result.
      
      MyID artifacts are not on Maven Central, and a consuming app re-resolves
      transitive dependencies against its own repository set, so the repositories are
      registered on all projects rather than only on this module. An opt-out property
      is provided for apps that manage repositories centrally.
      f790805c
    • Javokhir's avatar
      chore: replace demo app with react-native library scaffold · 9d97b218
      Javokhir authored
      Repo becomes the myid-sdk npm package: library at root, RN 0.86.2 vanilla
      example app in example/, Turbo Module codegen enabled, yarn 4 workspace.
      
      The previous demo app targeted MyID SDK 2.x (clientId, withPassportData,
      MyIdBuildMode), an API that no longer exists in 3.x, so it is removed rather
      than migrated. Recoverable via the pre-rewrite tag.
      9d97b218